fix: address #910, #911, #912, #913 - #952
Merged
Kingsman-99 merged 5 commits intoSep 28, 2026
Merged
Conversation
… spend limits Closes Stellar-split#911
|
@chemarhjohn-dev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix: address #910, #911, #912, #913
What was solved
#910 — Implement payment forwarding rules engine
Implement a payment forwarding rules engine in the Stellar SDK codebase: a module that evaluates configurable forwarding rules against incoming payments and dispatches/forwards them accordingly, with event handling and comprehensive tests. The issue is high-level and lacks concrete API details, so the contribution should introduce a focused, well-typed rules engine module plus a test file, following existing src/ patterns (e.g., ammCalculator.ts, approvalWorkflowSequencer.ts) and their tests counterparts.
Addressed:
#911 — Add SDK budget tracker — warn when approaching spend limits
Add an SDK budget tracker that monitors cumulative spend against configured limits and emits warnings as spend approaches those limits, with event handling and tests. The issue is high-level, so the contribution should introduce a focused tracker module (config, spend recording, threshold warnings/events) plus a test file, following existing SDK patterns.
Addressed:
#912 — Implement advanced filter DSL for invoice queries
Implement an advanced filter DSL for invoice queries, providing a typed, composable query language (field/operator/value predicates combined with AND/OR/NOT) that compiles to a predicate function and integrates with existing invoice querying surfaces. Includes event handling for filter lifecycle/query execution and comprehensive tests covering parsing, evaluation, and edge cases.
Addressed:
#913 — Add SDK caching layer with TTL and invalidation
Add an SDK caching layer with TTL-based expiration and invalidation support, including event handling and tests, while keeping the change focused on the caching module and its public surface.
Addressed:
Changes
src/paymentForwardingRulesEngine.ts(create)src/approvalWorkflowSequencer.ts(modify)src/budgetTracker.ts(create)src/__tests__/budgetTracker.test.ts(create)README.md(modify)src/cache.ts(modify)src/cache/OptimisticCache.ts(modify)src/index.ts(modify)Approach
Issues
Closes #910
Closes #911
Closes #912
Closes #913